Skip to content

Conversation

@hgreebe
Copy link
Contributor

@hgreebe hgreebe commented Aug 12, 2025

Description of changes

  • Adding PyPi dependencies for latest Python version 3.12 and using appropriate folder names
  • Installing Packages with --no-build-isolation as with Python 3.12.x so that we check for existing dependecies.
    ** packages are installed with isolation from Py 3.12, where they do not check if the dependencies they want already exist and try to install them again.
  • Installing efs-proxy dependecies from s3 in Isolated region as they cannot connect to cargo and get below error
Stdout: failed to download from `https://index.crates.io/config.json
Stdout: [6] Couldn't resolve host name (Could not resolve host: index.crates.io)
  • adding GIT_REF for cookbook util script for uploading it in S3

Tests

  • Build rhel8, AL2, and AL2023 AMIs in ADC
  • Ran isolated region integ tests

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@himani2411
Copy link
Contributor

Can you add description of why we made changes. I added some #2995

himani2411
himani2411 previously approved these changes Aug 12, 2025
@himani2411 himani2411 self-requested a review August 12, 2025 17:06
efs_proxy_deps = "efs-proxy-dependencies-#{package_version}.tar.gz"
efs_proxy_deps_tarball = "#{node['cluster']['sources_dir']}/#{efs_proxy_deps}"
efs_proxy_deps_url = "#{node['cluster']['artifacts_s3_url']}/dependencies/efs/#{efs_proxy_deps}"
efs_proxy_deps_url = "https://hgreebe-dependencies.s3.us-east-1.amazonaws.com/efs-proxy-dependencies-2.3.1.tar.gz?response-content-disposition=inline&X-Amz-Content-Sha256=UNSIGNED-PAYLOAD&X-Amz-Security-Token=IQoJb3JpZ2luX2VjEND%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FwEaCXVzLWVhc3QtMSJHMEUCIGOxxoNgJTA8hIZ5HlF4lhvf2MTAF38lUNxf3fVKMB%2BdAiEA5oK4dzIlE1dSprGPeO1niMhW%2BLpJuBpsEvp22sV6yMUq2gQIGBAAGgw5MTE4MDA3MzcyOTEiDFY0t1lV6j62wt5%2Bniq3BG3PWLdjrx1%2BeI5uja4vBdw2HbhSEY7QknUBwMniqH5rolSuP9KkxHrmUIvMIu64vGTtZn1UuArDxOeYzpZhl6YsygyAFsmkiwUuudSwEPxb%2BY9MbkXg2e2%2BryrnsEOKBmR3qxbegnnBbasWmoqiliBVnbOzCrH64wo%2FIspU%2BNulra%2FlfOlN1mJWmd%2F2o3fCKAFBV0xVvaLPw0xwGUjHeg%2BqkKNoZyMRFg8wYHugXHsU6hh9cPhuw%2F%2FKt2LGqmWTcl0UXgmBdOZl4reSMdOZBq8MX7J1pcoyPu0QuJXkLnNXBk8BvKhYTMpisRuZiYrmRUKAWpZ9wivA9sPAr8xLuF9CHxc51QUC4r3mXhAFUzGOhh%2F0%2Bs59inpOrHpZqnsEQi9304Ej0EZAoq5KggASPXaUkwz3ytfHODVbCP5dqd612u9pS1VpNEwA%2FCKF%2BztyOfS2O4fmYcjjbZzEvYyqoiRhq8k%2FyBV7q5c5UJT4SOaQPNnhaWcGsFAu99ypCY%2BZwJWv%2FEa%2FIwXqYuACRppV00t9H%2FIHpbIRdqJx7o6M2FLbGnzhub%2BFH3rOR2fajs6Sn482wSamXsRzQgjb9TvzEzglG9hIbj8OE8xKcQTc9AthAU3%2BGqWg%2FdyA5a2XICJQRECf10PWJlcr9KSTm%2FoIzBM0m4rZYN%2Bt59RS1kWjtzcciIaxOnZ2PNw1dPLKQIriiSZI12VhzlGsCsCYlWogqNHn%2B6Mwn%2F64XXVjzhykAh1v8XA%2BS7tI5DCBt%2B3EBjq3AjA01fNGvJYPnhUxWXL1y8kTPiFCQBILG4%2FuB5sBlQ1oT1dN3yX4uOcMqUT9FxDC4o80QWKuIOWmNtcOldpwpTetoYiA%2B3Pn3NtJkrlE522oF0czBR%2B%2B7VU5rvXT0793kQhaLajGXz4QX9kcWrTPMBKQ1%2FvFDAd3FW1lhRXn7v57Mq14ihXYdWcJc8%2B3Qb5lhs1egHBglFCISy7IJPHVthmEP8mzQYG8CZXk6KdK4j%2Bn%2FvVFaJjAicltKvo1kBooFmale2EVw4dcKnU6PW6poswXRo3j9vYDCYtDn1dH9OJ9SNnpEuJYbKLlzVrbwJ%2BfXfSqKjHoy9bPJg9JfwZGOXpEHWMozd%2BXpQ4H9ypkLPE2wHQExOwZY0DG0qfxV%2Fi9hVwKHrQ9ACIES6B%2BQ3d5eIv2b2oIvuZl&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=ASIA5IS4PDYFUGPXRCWB%2F20250812%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20250812T152010Z&X-Amz-Expires=43200&X-Amz-SignedHeaders=host&X-Amz-Signature=102fbd12eebe0731eea57412726c75f7257eb8d9927b18d32ab6a4c4013c4625"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this?

@hgreebe hgreebe force-pushed the release-3.13.2-isolated branch from cd32761 to ab36358 Compare August 13, 2025 17:31
@codecov
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.50%. Comparing base (98c689e) to head (d6df659).
⚠️ Report is 44 commits behind head on release-3.13.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-3.13    #3003   +/-   ##
=============================================
  Coverage         75.50%   75.50%           
=============================================
  Files                23       23           
  Lines              2356     2356           
=============================================
  Hits               1779     1779           
  Misses              577      577           
Flag Coverage Δ
unittests 75.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hgreebe hgreebe closed this Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants